fix: only show signup flash to newly created members - #2789
Merged
Conversation
The details page flashed "Thanks for signing up" to every incomplete member, including returning accounts sent there to finish their profile. Track whether the member was actually created during the OAuth callback (session[:new_member]) and gate the flash on it, so returning members land on the details page with no misleading signup message.
mroderick
marked this pull request as ready for review
August 6, 2026 16:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Returning members routed to the "Almost there..." details page (because their profile is incomplete) were still told "Thanks for signing up", even though no new account was created. The signup flash now shows only for members actually created during the OAuth callback; existing members land on the details page with no misleading message.
Test plan
Extended
auth_services_callback_spec.rband the details controller spec to cover both cases. The browser feature test for a genuine new signup still shows the flash. 21 examples, 0 failures; RuboCop clean.Fixes #2788